From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 04 Jun 2012 21:17:58 GMT
Subject: Re: [PATCHv5 4/4] Write to $XDG_CONFIG_HOME/git/config file
Message-ID: <vpq4nqqn5dl.fsf@bauges.imag.fr>
In-Reply-To: <1338754481-27012-4-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>

Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
writes:

> +test_expect_success 'write: xdg file exists and ~/.gitconfig doesn'\''t' '
> +	mkdir -p .config/git &&
> +	>.config/git/config &&
> +	rm .gitconfig &&
> +	git config --global user.name "write_config" &&
> +	echo "[user]" >expected &&
> +	echo "	name = write_config" >>expected &&
> +	test_cmp expected .config/git/config
> +'

It was suggested that you also write to the XDG file if the XDG
_directory_ exists. After thinking about it, I tend to disagree with
this, because creating ~/.config/git/ignore would let Git write to the
XDG configuration file as a side effect, which I find strange.

Anyway, you may add the case where ~/.config/git/ exists but not the
config file in it to your tests, to materialize the decision you have
taken on that point.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/