From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 23 Jul 2014 19:55:38 GMT
Subject: Re: [PATCH 2/7] rewrite git_config() to use the config-set API
Message-ID: <vpq4my7vohx.fsf@anie.imag.fr>
In-Reply-To: <1406140978-9472-3-git-send-email-tanayabh@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

> -int git_config(config_fn_t fn, void *data)
> +static int git_config_raw(config_fn_t fn, void *data)

As you noticed already, this change breaks several tests. You are going
to repair them later in the series, but your patch series produces a
non-bisectable history.

The history should pass tests at each commit. If needed, you can ensure
that with eg.

git rebase HEAD~7 --exec "make && cd t/ && ./t1308-config-set.sh && ./t4018-diff-funcname.sh" -i

(or --exec 'make test', but that takes really long)

So, this patch should come later in the series (not hard, just a
reordering with rebase -i).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/