From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 13 Aug 2014 13:10:48 GMT
Subject: Re: [PATCH v2 1/5] fast-import.c: replace `git_config()` with `git_config_get_*()` family
Message-ID: <vpq4mxgtu07.fsf@anie.imag.fr>
In-Reply-To: <53EB58A0.10307@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

> +	if (!git_config_get_int("pack.compression", &pack_compression_level)) {
> +		if (pack_compression_level == -1)
> +			pack_compression_level = Z_DEFAULT_COMPRESSION;
> +		else if (pack_compression_level < 0 ||
> +			 pack_compression_level > Z_BEST_COMPRESSION)
> +			git_die_config("pack.compression",
> +					"bad pack compression level %d", pack_compression_level);

Perfect. With v2 for PATCH 2 and PATCH 5, the series looks good to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/