From: Matthieu Moy Date: Mon, 08 Jun 2015 17:08:33 GMT Subject: Re: [PATCH v6 09/11] ref-filter: move code from 'for-each-ref' Message-ID: In-Reply-To: <1433673294-16243-1-git-send-email-karthik.188@gmail.com> Karthik Nayak writes: > --- a/builtin/for-each-ref.c > +++ b/builtin/for-each-ref.c > @@ -1129,7 +56,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) > > memset(&ref_cbdata, 0, sizeof(ref_cbdata)); > ref_cbdata.filter.name_patterns = argv; > - for_each_rawref(ref_filter_handler, &ref_cbdata); > + filter_refs(for_each_rawref, &ref_cbdata); This seems unrelated from the rest of the patch. And you haven't introduced filter_refs yet! -- Matthieu Moy http://www-verimag.imag.fr/~moy/