From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 11 Jun 2015 19:13:28 GMT
Subject: Re: [PATCH v7 05/12] for-each-ref: introduce new structures for better organisation
Message-ID: <vpq4mmeqcrr.fsf@anie.imag.fr>
In-Reply-To: <5579CBE0.3050301@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> On 06/11/2015 11:11 PM, Matthieu Moy wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>> > +struct ref_filter_cbdata {
>> > +    struct ref_array array;
>> > +    struct ref_filter filter;
>> > +};
>>
>> I didn't notice this at first, but why introduce the structure like this
>> when you are going to turn it into pointers later in PATCH 7:
> Here it is serving to for-each-ref, so I kept it this way so as to ensure
> that currently as per this patch
>
> struct ref_filter_cbdata ref_cbdata;
>
> would be the only declaration needed in for-each-ref.c
> If I made them pointers here I would need to have
>
> struct ref_filter_cbdata ref_cbdata;
> struct ref_filter filter;
> struct ref_array array;
> ref_cbdata.filter = &filter;
> ref_cbdata.array = &array;

... but after PATCH 7, filter and array are passed to ref_filter so you
don't have this overhead anyway. Makes sense.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/