From: Matthieu Moy Date: Sun, 13 Sep 2015 12:15:36 GMT Subject: Re: [PATCH v4 4/8] branch: move 'current' check down to the presentation layer Message-ID: In-Reply-To: <1442129035-31386-5-git-send-email-Karthik.188@gmail.com> Karthik Nayak writes: > We check if given ref is the current branch in print_ref_list(). Move > this check to print_ref_item() where it is checked right before > printing. You may want to add a sentence saying why this is good. Given the context, it's relatively clear that this makes the code closer to the shape expected by ref-filter, but if you imagine someone bisecting or blaming and finding this commit in another context, that person may appreciate more explanation. -- Matthieu Moy http://www-verimag.imag.fr/~moy/