From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 15 Oct 2015 19:21:53 GMT
Subject: Re: [PATCH 2/3] stripspace: Implement --count-lines option
Message-ID: <vpq4mhsx7hq.fsf@grenoble-inp.fr>
In-Reply-To: <1444911524-14504-3-git-send-email-tklauser@distanz.ch>

Tobias Klauser <tklauser@distanz.ch> writes:

> + * comments are considered contents to be removed or not. Returns the
> + * number of lines in the resulting buffer.

We write comments at imperative tone, hence "Return", not "Returns".

Other than that, I agree with Junio:

* A preparatory patch introducing parse-options would make the actual
  patch much easier to review.

* Just running strbuf_stripspace and counting the number of lines in the
  result is much simpler. We use stripspace only on user-provided input
  which are never really big so maintainability is more important than
  performance.

Cheers,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/