From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 19 Oct 2015 19:42:58 GMT
Subject: Re: [PATCH v2 3/4] stripspace: Implement --count-lines option
Message-ID: <vpq4mhmablp.fsf@grenoble-inp.fr>
In-Reply-To: <CAPig+cR4wyumSfzXjptCfniuN0QC8TErL1X9LDPMsCD8wHP_kA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> With this in mind, my
> question was also indirectly asking whether there was sufficient
> justification of the long-term cost of a --count-lines option. The
> argument that --count-lines would help test a proposed
> strbuf_count_lines() likely does not outweigh that cost.

I agree. If we expect users to call --count-lines outside
rebase-interactive.sh and our own tests, then the actual use should be
justified in the commit message.

If not, then at least the --count-lines option should be hidden and not
documented in the public doc. But I agree that introducing test-strbuf
would be even better.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/