From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 07 Feb 2013 18:46:48 GMT
Subject: Re: [PATCHv2 4/5] Git.pm: add interface for git credential command
Message-ID: <vpq38x8m06f.fsf@grenoble-inp.fr>
In-Reply-To: <78516627e893e54d5aafe0694d1face9a37893de.1360242782.git.mina86@mina86.com>

Michal Nazarewicz <mpn@google.com> writes:

> From: Michal Nazarewicz <mina86@mina86.com>
>
> Add a credential() function which is an interface to the git
> credential command.  The code is heavily based on credential_*
> functions in <contrib/mw-to-git/git-remote-mediawiki>.

I'm no perl expert, so I cannot comment much on style (there are many
small changes compared to the mediawiki code that look like improvement
though), but:

Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/