From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 10 Sep 2015 16:53:09 GMT
Subject: Re: [PATCH v17 06/14] ref-filter: implement an `align` atom
Message-ID: <vpq37ymp66i.fsf@scolette.imag.fr>
In-Reply-To: <1441900110-4015-7-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> +			/*
> +			 * TODO: Implement a function similar to strbuf_split_str()
> +			 * which would omit the separator from the end of each value.
> +			 */
> +			s = to_free = strbuf_split_str(valp, ',', 0);
> +
> +			align->position = ALIGN_LEFT;
> +
> +			while (*s) {
> +				if (s[1])

A comment like /* strip trailing ',' */ here would really help the
reader IMHO.

> +					strbuf_setlen(s[0], s[0]->len - 1);

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/