From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 29 Sep 2009 18:03:25 GMT
Subject: Re: clone from url with email address as username?(escaping @ symbol)
Message-ID: <vpq1vlpr5le.fsf@bauges.imag.fr>
In-Reply-To: <970bc7c80909291051q5dff9209u650cee4f84d92fae@mail.gmail.com>

Ben Bennett <benbennett@gmail.com> writes:

> Is it escaping the %40 when passed down? I am getting an error 401  ,
> and checking the server logs , it is passing the %40 to the server in
> the username.
> Running curl from command line , I can connect, but through git , the
> username is getting mangled or I have something screwed up.

OK, so it seems Git should be fixed to unescape this %40 somewhere,
most likely in http_auth_init in http.c, in addition to by fix below.
http://curl.haxx.se/libcurl/c/curl_easy_unescape.html might help. I've
consumed by Git time budget for now, so if anyone else can have a
look ...

>> --- a/http.c
>> +++ b/http.c
>> @@ -281,9 +281,10 @@ static void http_auth_init(const char *url)
>>         * "proto://<host>/..."?
>>         */
>>        cp += 3;
>> -       at = strchr(cp, '@');
>>        colon = strchr(cp, ':');
>>        slash = strchrnul(cp, '/');
>> +       for(at = slash-1; *at != '@' && *at != '/'; at--)
>> +               continue;
>>        if (!at || slash <= at)
>>                return; /* No credentials */
>>        if (!colon || at <= colon) {
>>

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/