From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 03 Jun 2010 14:47:51 GMT
Subject: Re: [PATCH 0/4] Don't warn about missing EOL for symlinks
Message-ID: <vpq1vco41go.fsf@bauges.imag.fr>
In-Reply-To: <cover.1275575236.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

> "No newline at end of file" always confuses me when looking at a diff for
> symlinks. "File? Huh? Didn't Git recognize my symlink?"

For interactive use, I do understand. But how do you deal with the
(improbable) case of a user actually adding a newline at the end of
the target of the symlink, and then using format-patch and am to apply
the changes somewhere else?

You probably want to make sure your patch doesn't modify format-patch.

BTW, I disagree that the message is a "warning": it's actually a piece
of information, part of the patch, but that we find annoying in this
case.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/