From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 04 Jun 2010 08:49:41 GMT
Subject: Re: [RFC/PATCH 4/4] t/t8006: test textconv support for blame
Message-ID: <vpq1vcnqj16.fsf@bauges.imag.fr>
In-Reply-To: <1275562038-7468-5-git-send-email-axel.bonnet@ensimag.imag.fr>

Axel Bonnet <axel.bonnet@ensimag.imag.fr> writes:

> +test_expect_success 'blame with --no-textconv' '
> +	git blame --no-textconv one.bin | grep Number2 >blame
> +	find_blame <blame >result
> +	test_cmp expected result
> +'

Don't you want to add && at each end of line, to make sure you catch
potential failures of git blame on the first line (e.g. git blame
producing the correct output and then segfaulting for example)?

Actually, to really catch such failures, you should not run git on the
left hand side of a | (otherwise, you look for failures of the right
hand side), and do this instead:

test_expect_success 'no filter specified' '
	git blame one.bin >to-grep &&
	grep Number2 to-grep >blame &&
	find_blame <blame >result &&
	test_cmp expected result
'

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/