From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 11 Jun 2013 16:35:32 GMT
Subject: Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions
Message-ID: <vpq1u8838rv.fsf@anie.imag.fr>
In-Reply-To: <7vsj0od6z5.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Célestin Matte <celestin.matte@ensimag.fr> writes:
>
>> Subroutines' parameters should be affected to variable before doing anything
>> else
>> Besides, existing instruction affected a variable inside a "if", which break
>> Git's coding style
>
> I think s/affect/assign/g is what you meant.

Yes, common false friends for French people ;-).

>       my ($namespace) = @_;
> 	my $namespace = shift;
>
> My impression has been that both are equally common,

The second is the most common in git-remote-mediawiki (but I don't have
any preference nor know what is recommended elsewhere).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/