From: Matthieu Moy Date: Wed, 30 Jul 2014 13:46:30 GMT Subject: Re: [PATCH v4 0/5] git_config callers rewritten with the new config cache API Message-ID: In-Reply-To: <1406727549-22334-1-git-send-email-tanayabh@gmail.com> Tanay Abhra writes: > [PATCH v4]: Tiny style nits corrected. Patch 2/5 has been totally reworked. > One thing to check is if the config variables I changed in the series > are single valued or multi valued. Though I have tried to ascertain > if the variable was single valued or not by reading the docs and code, > mistakes may creep in. > > [PATCH v3]: Most of Eric's suggestions has been implemented. See [2] for discussion. > Also, new helpers introduced in v7 of the config-set API series have been used. > > This series builds on the top of 4c715ebb in pu (ta/config-set). I think it semantically needs your other WIP series, that makes git_config_get_* die in case of error. Otherwise, there's an unexpected behavior change in case of error. -- Matthieu Moy http://www-verimag.imag.fr/~moy/