From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 05 Oct 2015 08:49:48 GMT
Subject: Re: [PATCH 6/9] ref-filter: introduce format_ref_array_item()
Message-ID: <vpq1td9zolv.fsf@grenoble-inp.fr>
In-Reply-To: <CAOLa=ZTMf9i=+9Rgi9oO==vr_JGtG3J9DvQWk18Zx-yd5_35XA@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> The problem is with colors which tag.c doesn't use by default.
> Here we need to print colors only if we're printing to a tty which supports
> colors.

Ah, and tag --format '%(color:...)' does not do the tty autodetection.

> which does not play well with the implementation of --column as done
> in tag.c. Where, If I'm not wrong the --column option captures all
> output, formats it and then prints it to stdout. Hence when using
> colors, we're told that the printing isn't done to a tty which
> supports colors, hence we lose out on colors.

What I don't understand is how --column is different from --no-column
wrt colors.

In any case, this should be explained better in comments.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/