From: Brandon Casey Date: Thu, 11 Mar 2010 23:57:01 GMT Subject: Re: [PATCH 5/5] struct sockaddr_storage->ss_family is not portable Message-ID: In-Reply-To: <20100311222722.GB18292@sigill.intra.peff.net> On 03/11/2010 04:27 PM, Jeff King wrote: > On Thu, Mar 11, 2010 at 04:37:15PM +0000, Gary V. Vaughan wrote: > >> Actually, the test for setting NO_IPV6 at configure time is still >> too optimistic and I have to manually pass '-DNO_IPV6' in CPPFLAGS >> at build time on aix-5.2.0.0 and earlier, and irix-6.5 and older >> for them to pick up the right branch. > > Are you running 'configure' or just 'make'? If the latter, then the > defaults for each platform are defined in the Makefile (e.g., see around > line 790 of the Makefile where we turn off IPv6 for Solaris 2.7, but not > 2.8). Patches to tweak the defaults for obscure platforms are welcome. > > Also, now that I look at that, we seem to already have a > NO_SOCKADDR_STORAGE flag that handles this case? Does setting that fix > your problem without this patch? NO_SOCKADDR_STORAGE is already set for Solaris 7, and still daemon.c can not be compiled since ss_family started being used, I think in 15515b73. I should probably speak up when things break, but I tend to remain silent if I don't have the time to investigate. -brandon