From: Josh Steadmon <steadmon@google.com>
Date: Thu, 31 Oct 2024 22:33:41 GMT
Subject: Re: [PATCH v2 0/2] When fetching, die if in commit graph but not obj db
Message-ID: <sbfnqtf5phdstpfrsahxiz5orzhgblflvghyni462aew4n7pe2@74cnj2vjuby3>
In-Reply-To: <cover.1730409376.git.jonathantanmy@google.com>

On 2024.10.31 14:18, Jonathan Tan wrote:
> Thanks everyone for your review comments. I've updated the patch 1
> commit message as Josh requested. I'll reply individually to comments on
> patch 2.
> 
> Jonathan Tan (2):
>   Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"
>   fetch-pack: warn if in commit graph but not obj db
> 
>  fetch-pack.c                               | 42 +++++++++++-----------
>  t/t5330-no-lazy-fetch-with-commit-graph.sh |  2 +-
>  2 files changed, 23 insertions(+), 21 deletions(-)

This version looks good to me, thanks!

Reviewed-by: Josh Steadmon <steadmon@google.com>