From: Robin H. Johnson Date: Fri, 07 Jan 2011 22:53:53 GMT Subject: Re: [PATCH] git-cvs*: Make building (and testing) of CVS interface scripts optionally selectable Message-ID: In-Reply-To: <7v39p45pyw.fsf@alter.siamese.dyndns.org> On Fri, Jan 07, 2011 at 02:05:59PM -0800, Junio C Hamano wrote: > > Presently, the CVS interface scripts are always built, and their > > test-suites run based on a binary named 'cvs' happening to return zero. > > If there something other than the real CVS there, bad things happened > > during the test-suite run. > It makes sense to let people whose system happens to have a working cvs to > omit cvs interoperability bits when they know the do not want them, and > that alone would be a good enough motivation. Ok, i'll respin to a different explanation. > While the patch looks good, some people seem to prefer skipping individual > tests without shortcut; see 900eab4 (t/t9600-cvsimport.sh: change from > skip_all=* to prereq skip, 2010-08-13) for example. I am slightly in > favor of the short-cut as I haven't heard convincing argument against it > other than "skipped statistics" which I don't think is interesting nor > accurate anyway. I did it this was because of your prior comment on my perl prereq patch for the send-email tests. > I wonder if "check PERL and CVS prerequisite and say test_done" should be > made into a helper in lib-cvs.sh or somewhere instead of repeating them in > individual tests, but that is a minor point. I'll see if I can respin to do this. -- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85