From: Brandon Casey Date: Fri, 10 Sep 2010 16:13:38 GMT Subject: [PATCH] t/t4018: avoid two unnecessary sub-shell invocations Message-ID: In-Reply-To: <20100909195904.GE1146@sigill.intra.peff.net> From: Brandon Casey Signed-off-by: Brandon Casey --- Thanks again Jeff for your, as always, very valuable review. t/t4018-diff-funcname.sh | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh index 620cd02..c8e1937 100755 --- a/t/t4018-diff-funcname.sh +++ b/t/t4018-diff-funcname.sh @@ -37,13 +37,13 @@ for p in $builtin_patterns do test_expect_success "builtin $p pattern compiles" ' echo "*.java diff=$p" > .gitattributes && - ! ( git diff --no-index Beer.java Beer-correct.java 2>&1 | - grep "fatal" > /dev/null ) + ! { git diff --no-index Beer.java Beer-correct.java 2>&1 | + grep "fatal" > /dev/null; } ' test_expect_success "builtin $p wordRegex pattern compiles" ' - ! ( git diff --no-index --word-diff \ + ! { git diff --no-index --word-diff \ Beer.java Beer-correct.java 2>&1 | - grep "fatal" > /dev/null ) + grep "fatal" > /dev/null; } ' done -- 1.7.2.1