From: Tay Ray Chuan Date: Fri, 23 Apr 2010 04:15:56 GMT Subject: Re: [PATCH 2/2] wt-status: take advice.statusHints seriously Message-ID: In-Reply-To: <86a4d8e5df80008c5c2b3ff4f2a5842ad1f58dc4.1271968072.git.git@drmicha.warpmail.net> Hi, On Fri, Apr 23, 2010 at 4:30 AM, Michael J Gruber wrote: >                else if (s->untracked.nr) > -                       printf("nothing added to commit but untracked files present (use \"git add\" to track)\n"); > +                       printf("nothing added to commit but untracked files present%s\n", > +                               advice_status_hints > +                               ? " (use \"git add\" to track)" : ""); while we're at it, perhaps we could put the hints on its own line, with a "hint: " prefix: nothing added to commit but untracked files present hint: use "git add" to track This way, we give future git usability hackers the space to elaborate further on why a certain flag or command was recommended. -- Cheers, Ray Chuan