From: Srujith A Poojary via GitGitGadget Date: Wed, 11 Nov 2026 12:45:42 GMT Subject: [PATCH v5] archive-tar: add comments explaining configuration precedence Message-ID: In-Reply-To: From: Srujith A Poojary Document the initialization order in init_tar_archiver() to clarify that built-in default filters are registered before repo_config() is called, ensuring user configuration correctly overrides defaults. Signed-off-by: Srujith A Poojary --- [Outreachy PATCH] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules Refactored archive-tar.c, archive-zip.c, archive.c, and supporting files to use explicit struct repository *repo pointers instead of global repository variables. Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2305%2Fpoojarysrujith%2Farchive-libification-refactor-v5 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2305/poojarysrujith/archive-libification-refactor-v5 Pull-Request: https://github.com/gitgitgadget/git/pull/2305 Range-diff vs v4: 1: 29130b6eb2 ! 1: 47172b861b archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules @@ Metadata Author: Srujith A Poojary ## Commit message ## - archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules + archive-tar: add comments explaining configuration precedence - Refactor archive-tar.c and builtin/archive.c to clean up archiver - initialization order and header dependencies. + Document the initialization order in init_tar_archiver() to clarify + that built-in default filters are registered before repo_config() is + called, ensuring user configuration correctly overrides defaults. Signed-off-by: Srujith A Poojary archive-tar.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/archive-tar.c b/archive-tar.c index a1c66024d4..1b376d048a 100644 --- a/archive-tar.c +++ b/archive-tar.c @@ -531,11 +531,15 @@ void init_tar_archiver(void) int i; register_archiver(&tar_archiver); + /* Set built-in defaults first so user config can override them */ tar_filter_config("tar.tgz.command", internal_gzip_command, NULL); tar_filter_config("tar.tgz.remote", "true", NULL); tar_filter_config("tar.tar.gz.command", internal_gzip_command, NULL); tar_filter_config("tar.tar.gz.remote", "true", NULL); + + /* Load repository config so user settings override the defaults above */ repo_config(the_repository, git_tar_config, NULL); + for (i = 0; i < nr_tar_filters; i++) { /* omit any filters that never had a command configured */ if (tar_filters[i]->filter_command) base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd -- gitgitgadget