From: Nikolaus Schuetz via GitGitGadget Date: Wed, 26 Aug 2026 16:51:47 GMT Subject: [PATCH v3] t1401: check symbolic-ref failure and --quiet silence on a non-symbolic ref Message-ID: In-Reply-To: From: Nikolaus Schuetz git-symbolic-ref(1) documents that reading a name that is not a symbolic ref fails, and that --quiet does so silently. Tests such as t2020 and t5621 already rely on "symbolic-ref -q HEAD" failing on a detached HEAD, but none checks that the plain form reports the error or that --quiet stays silent. Assert that a non-symbolic ref fails with the "is not a symbolic ref" message, and that --quiet fails with no output. Use test_must_fail rather than pinning the exact exit codes, which are documented but not worth freezing in the test. Signed-off-by: Nikolaus Schuetz --- t1401: test symbolic-ref exit codes on a non-symbolic ref git-symbolic-ref(1) documents that reading a name that is not a symbolic ref exits with a non-zero status, and that --quiet does so silently rather than printing a diagnostic. This exit-code contract was untested. This adds two tests: querying a non-symbolic ref exits 128 with the usual "is not a symbolic ref" message, and --quiet instead exits 1 with no output. Test-only; documents existing behaviour, in the spirit of 919eb8ace (t1402: check for refs ending with a dot). Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2204%2Fnikolauspschuetz%2Fns%2Ft1401-symbolic-ref-quiet-v3 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2204/nikolauspschuetz/ns/t1401-symbolic-ref-quiet-v3 Pull-Request: https://github.com/gitgitgadget/git/pull/2204 Range-diff vs v2: 1: 22694da869 ! 1: 0391dcceef t1401: check symbolic-ref exit codes and --quiet silence @@ Metadata Author: Nikolaus Schuetz ## Commit message ## - t1401: check symbolic-ref exit codes and --quiet silence + t1401: check symbolic-ref failure and --quiet silence on a non-symbolic ref git-symbolic-ref(1) documents that reading a name that is not a - symbolic ref exits non-zero, and that --quiet does so silently. - Tests such as t2020 and t5621 already rely on "symbolic-ref -q HEAD" - failing on a detached HEAD, but none pins the exact exit codes or - checks that --quiet actually suppresses the diagnostic. + symbolic ref fails, and that --quiet does so silently. Tests such as + t2020 and t5621 already rely on "symbolic-ref -q HEAD" failing on a + detached HEAD, but none checks that the plain form reports the error + or that --quiet stays silent. - Assert that a non-symbolic ref exits 128 with the "is not a symbolic - ref" message, and that --quiet instead exits 1 with no output. + Assert that a non-symbolic ref fails with the "is not a symbolic ref" + message, and that --quiet fails with no output. Use test_must_fail + rather than pinning the exact exit codes, which are documented but not + worth freezing in the test. Signed-off-by: Nikolaus Schuetz @@ t/t1401-symbolic-ref.sh: test_expect_success 'symbolic-ref refuses bare sha1' ' reset_to_sane -+test_expect_success 'symbolic-ref reports a non-symbolic ref with exit code 128' ' -+ test_expect_code 128 git symbolic-ref refs/heads/foo >out 2>err && ++test_expect_success 'symbolic-ref reports a non-symbolic ref' ' ++ test_must_fail git symbolic-ref refs/heads/foo >out 2>err && + test_must_be_empty out && + test_grep "is not a symbolic ref" err +' + -+test_expect_success 'symbolic-ref -q is silent and exits 1 on a non-symbolic ref' ' -+ test_expect_code 1 git symbolic-ref -q refs/heads/foo >out 2>err && ++test_expect_success 'symbolic-ref -q is silent on a non-symbolic ref' ' ++ test_must_fail git symbolic-ref -q refs/heads/foo >out 2>err && + test_must_be_empty out && + test_must_be_empty err +' t/t1401-symbolic-ref.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh index a2a7e94716..fd3aa89a91 100755 --- a/t/t1401-symbolic-ref.sh +++ b/t/t1401-symbolic-ref.sh @@ -38,6 +38,18 @@ test_expect_success 'symbolic-ref refuses bare sha1' ' reset_to_sane +test_expect_success 'symbolic-ref reports a non-symbolic ref' ' + test_must_fail git symbolic-ref refs/heads/foo >out 2>err && + test_must_be_empty out && + test_grep "is not a symbolic ref" err +' + +test_expect_success 'symbolic-ref -q is silent on a non-symbolic ref' ' + test_must_fail git symbolic-ref -q refs/heads/foo >out 2>err && + test_must_be_empty out && + test_must_be_empty err +' + test_expect_success 'HEAD cannot be removed' ' test_must_fail git symbolic-ref -d HEAD ' base-commit: 745601a9a94110d74769ab605ccd4f61339758d2 -- gitgitgadget