From: AZero13 via GitGitGadget Date: Thu, 20 Nov 2025 21:43:36 GMT Subject: [PATCH v3] win32: pthread_cond_init should return a value Message-ID: In-Reply-To: From: Greg Funni This value is not checked, but it must return to match POSIX Signed-off-by: Greg Funni --- win32: pthread_cond_init should return a value This value is not checked, but it must return to match POSIX Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2103%2FAZero13%2Fpthread-v3 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2103/AZero13/pthread-v3 Pull-Request: https://github.com/git/git/pull/2103 Range-diff vs v2: 1: a2d9ec97f1 ! 1: 19ce5aca70 win32: pthread_cond_wait should return a value @@ Metadata Author: Greg Funni ## Commit message ## - win32: pthread_cond_wait should return a value + win32: pthread_cond_init should return a value This value is not checked, but it must return to match POSIX compat/win32/pthread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h index e2b5c4f64c..000604cdf6 100644 --- a/compat/win32/pthread.h +++ b/compat/win32/pthread.h @@ -34,7 +34,7 @@ typedef int pthread_mutexattr_t; #define pthread_cond_t CONDITION_VARIABLE -#define pthread_cond_init(a,b) InitializeConditionVariable((a)) +#define pthread_cond_init(a,b) return_0((InitializeConditionVariable((a)), 0)) #define pthread_cond_destroy(a) do {} while (0) #define pthread_cond_wait(a,b) return_0(SleepConditionVariableCS((a), (b), INFINITE)) #define pthread_cond_signal WakeConditionVariable base-commit: 5e6e4854e086ba0025bc7dc11e6b475c92a2f556 -- gitgitgadget