From: Josh Steadmon <steadmon@google.com>
Date: Mon, 06 May 2024 19:58:09 GMT
Subject: Re: [PATCH v5 6/7] t/Makefile: run unit tests alongside shell tests
Message-ID: <pqtplukr2sni4vhgxjfr5u3bsoinjukopggktzgfvdzpceibpm@judi4dfpaz3h>
In-Reply-To: <xmqqle4uy328.fsf@gitster.g>

On 2024.04.30 14:05, Junio C Hamano wrote:
> Josh Steadmon <steadmon@google.com> writes:
> 
> > +# A simple wrapper to run shell tests via TEST_SHELL_PATH,
> > +# or exec unit tests directly.
> > +
> > +case "$1" in
> > +*.sh)
> > +	if test -z "${TEST_SHELL_PATH+set}"
> > +	then
> > +		echo >&2 "ERROR: TEST_SHELL_PATH is empty or not set"
> > +		exit 1
> > +	fi
> > +	exec ${TEST_SHELL_PATH} "$@"
> 
> You want to be prepared for a path like "//C/My Programs/bash".
> 
> 	exec "$TEST_SHELL_PATH" "$@"
> 
> > +	;;
> > +*)
> > +	exec "$@"
> > +	;;
> > +esac

Fixed in V6.