From: Ævar Arnfjörð Bjarmason Date: Tue, 19 Jul 2022 20:46:54 GMT Subject: [PATCH v2 03/24] submodule--helper: fix trivial get_default_remote_submodule() leak Message-ID: In-Reply-To: Fix a leak in code added in 1012a5cbc3f (submodule--helper run-update-procedure: learn --remote, 2022-03-04), we need to free() the xstrdup()'d string. This gets e.g. t/t7419-submodule-set-branch.sh closer to passing under SANITIZE=leak. Signed-off-by: Ævar Arnfjörð Bjarmason --- builtin/submodule--helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 4155d2450e0..b36919b66c5 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -2473,6 +2473,8 @@ static int update_submodule(struct update_data *update_data) const char *branch = remote_submodule_branch(update_data->sm_path); char *remote_ref = xstrfmt("refs/remotes/%s/%s", remote_name, branch); + free(remote_name); + if (!update_data->nofetch) { if (fetch_in_submodule(update_data->sm_path, update_data->depth, 0, NULL)) -- 2.37.1.1062.g385eac7fccf