From: Matthias Urlichs <smurf@smurf.noris.de>
Date: Mon, 19 Sep 2005 14:42:47 GMT
Subject: Re: [PATCH] Added -d and -e options to the "git" script.
Message-ID: <pan.2005.09.19.14.42.44.111271@smurf.noris.de>
In-Reply-To: <u5tmzm9bbrb.fsf@lysator.liu.se>

Hi, David Kågedal wrote:
> +        case "$1" in
> +        -e)	[...]
> +        *)	cmd="$1"
> +                shift
> +                case "$cmd" in
> +                -v|--v|--ve|--ver|--vers|--versi|--versio|--version)

Umm, can we please not have two case statements nested like that?

Better written as:
> +        case "$1" in
> +        -e)	[...]
> +        -v|--v|--ve|--ver|--vers|--versi|--versio|--version)
> +             [print and die]
> +        *)	cmd="$1"
> +             shift
> +             test -x $path/git-$cmd && exec $path/git-$cmd "$@"

Thanks.

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
It is a sad commentary on today's society that this fortune has to be
classified as "offensive" simply because it contains the word "fuck".