From: Linus Arver <linusa@google.com>
Date: Sun, 28 Jan 2024 05:01:19 GMT
Subject: Re: [PATCH v2 09/10] trailer: move arg handling to interpret-trailers.c
Message-ID: <owlyh6iy2grk.fsf@fine.c.googlers.com>
In-Reply-To: <1b4bdde65bcb375ce9ef2345814330df92e6d932.1706308737.git.gitgitgadget@gmail.com>

"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

> diff --git a/trailer.h b/trailer.h
> index c6aa96dd6be..e01437160cf 100644
> --- a/trailer.h
> +++ b/trailer.h
> @@ -46,9 +46,20 @@ struct new_trailer_item {
>  	enum trailer_if_missing if_missing;
>  };
>
> +void trailer_conf_set(enum trailer_where where,
> +		      enum trailer_if_exists if_exists,
> +		      enum trailer_if_missing if_missing,
> +		      struct trailer_conf *conf);
> +
> +struct trailer_conf *new_trailer_conf(void);
>  void duplicate_trailer_conf(struct trailer_conf *dst,
>  			    const struct trailer_conf *src);
>
> +const char *default_separators(void);
> +
> +void add_arg_item(char *tok, char *val, const struct trailer_conf *conf,
> +		  struct list_head *arg_head);

Looks like I forgot to add a "trailer" keyword for these API functions.
Will rename to "trailer_default_separators()" and
"trailer_add_arg_item()" in next reroll.