From: Linus Arver <linusa@google.com>
Date: Sun, 14 Jan 2024 20:05:53 GMT
Subject: Re: [PATCH 00/10] Enrich Trailer API
Message-ID: <owlycyu3ista.fsf@fine.c.googlers.com>
In-Reply-To: <owlyil3yhv70.fsf@fine.c.googlers.com>

Linus Arver <linusa@google.com> writes:

>     interpret-trailers: fail if given unrecognized arguments
>       (Summary: E.g., for "--where", only accept recognized WHERE_* enum
>       values. If we get something unrecognized, fail with an error
>       instead of silently doing nothing. Ditto for "--if-exists" and
>       "--if-missing".)
>
> The last one is a different class of bug than the first two, and perhaps
> less interesting.

Actually, upon closer inspection I realize that we already fail if given
unrecognized arguments to --where, --if-exists, and --if-missing. But we
don't explain why to the user because no error message is printed. This
commit has been retitled to "interpret-trailers: print error if given
unrecognized arguments".

Thanks.