From: Linus Arver <linusa@google.com>
Date: Sat, 03 Feb 2024 01:40:49 GMT
Subject: Re: [PATCH v3 09/10] trailer: delete obsolete argument handling code from API
Message-ID: <owly5xz61g0u.fsf@fine.c.googlers.com>
In-Reply-To: <xmqqplxfx1nk.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Linus Arver <linusa@google.com>
>>
>> This commit was not squashed with its parent in order to keep the diff
>> separate (to make the additive changes in the parent easier to read).
>
> Hopefully we won't see such an artificial separation in the new
> iteration.  As we saw, being able to compare before and after images
> in a single patch is useful while reviewing a change that is supposed
> to be making things cleaner without altering what they do.

Totally agree (and I'm reaping the benefits of this as well in the
smaller preparatory refactoring changes I've made for the next reroll).