From: Matthias Andree <matthias.andree@gmx.de>
Date: Sat, 09 May 2009 18:17:01 GMT
Subject: Re: [PATCH v3] To make GIT-VERSION-FILE, search for git more widely
Message-ID: <op.utoc2njr1e62zd@merlin.emma.line.org>
In-Reply-To: <7vskje6wsy.fsf@alter.siamese.dyndns.org>

Am 09.05.2009, 18:55 Uhr, schrieb Junio C Hamano <gitster@pobox.com>:

> "Matthias Andree" <matthias.andree@gmx.de> writes:
>
>>> Fine then.  Or you could just append "." to the $PATH ;-)
>>
>> "." in the super user's PATH? Cool stuff, and so innovative.
>
> I didn't mean to suggest PATH=$PATH:. *in the user's environment* ;-).
> You do that inside GIT-VERSION-FILE, which is essentially the same thing
> as running ./git$X from there.
>
> What's innovative is whoever is running build as root.

Back to the real problem, and that is re-checking GIT-VERSION-FILE as part
of "make install". I wonder if we should just have GIT-VERSION-GEN exit if
git isn't in $PATH, and at most copy version there -- rather than stomp
the DEF_VER somewhere.

-- 
Matthias Andree