From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 02 Nov 2021 14:57:01 GMT
Subject: Re: [PATCH v3 4/8] t1051: introduce a smudge filter test for extremely large files
Message-ID: <nycvar.QRO.7.76.6.2111021556480.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqo877h1x5.fsf@gitster.g>

Hi Junio,

On Fri, 29 Oct 2021, Junio C Hamano wrote:

> "Matt Cooper via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Matt Cooper <vtbassmatt@gmail.com>
> >
> > The filter system allows for alterations to file contents when they're
> > added to the database or workdir. ("Smudge" when moving to the workdir;
> > "clean" when moving to the database.) This is used natively to handle CRLF
> > to LF conversions. It's also employed by Git-LFS to replace large files
> > from the workdir with small tracking files in the repo and vice versa.
>
> Not a huge deal, but make it a habit to spell "working tree" not "workdir",
> as someday you'd write end-user facing documentation in our tree ;-).
>
> > Git pulls the entire smudged file into memory.
>
> Giving "for what" would be helpful to readers.
>
>     Git reads the entire smudged file into memory to convert it into
>     a "clean" form to be used in-core.

I changed both.

Ciao,
Dscho