From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 14 Aug 2021 21:48:56 GMT
Subject: Re: [PATCH 0/3] some small range-diff read_patches() fixes
Message-ID: <nycvar.QRO.7.76.6.2108142348390.59@tvgsbejvaqbjf.bet>
In-Reply-To: <65b00c6a-ef88-29c3-157b-24ad9f4d8a8c@gmail.com>

Hi,

On Tue, 10 Aug 2021, Derrick Stolee wrote:

> On 8/9/2021 6:45 PM, Jeff King wrote:
> > Amidst all the talk of clang4 in another thread, I noticed that Debian
> > unstable recently shipped a clang-14 package. So I tried it out, and it
> > does find one small cleanup. And then looking at the surrounding code
> > helped me find 2 more. :)
> >
> >   [1/3]: range-diff: drop useless "offset" variable from read_patches()
> >   [2/3]: range-diff: handle unterminated lines in read_patches()
> >   [3/3]: range-diff: use ssize_t for parsed "len" in read_patches()
>
> I gave these a read. The code diffs are obviously correct and the
> explanations are well motivated. Thanks.

Same here. Thanks, both,
Dscho