From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 10 Jun 2021 08:36:24 GMT
Subject: Re: [PATCH 3/4] *: fix typos
Message-ID: <nycvar.QRO.7.76.6.2106101029490.57@tvgsbejvaqbjf.bet>
In-Reply-To: <c40ad4a058a75d57adc97b8252ad0f57600b8d86.1623085069.git.gitgitgadget@gmail.com>

Hi,

On Mon, 7 Jun 2021, Derrick Stolee via GitGitGadget wrote:

> diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
> index 5c47ac4465cb..7039b5c6028d 100755
> --- a/t/t9300-fast-import.sh
> +++ b/t/t9300-fast-import.sh
> @@ -1538,7 +1538,7 @@ test_expect_success 'O: comments are all skipped' '
>  	commit refs/heads/O1
>  	# -- ignore all of this text
>  	committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE
> -	# $GIT_COMMITTER_NAME has inserted here for his benefit.
> +	# $GIT_COMMITTER_NAME has inserted here for this benefit.

What is this even supposed to mean? I fail to parse that sentence in both
original and modified forms.

Looking at 401d53fa350 (Teach fast-import to ignore lines starting with
'#', 2007-08-01), where the comment was added, I deduce from the commit
message that the personal pronoun _was_ actually intended.

So maybe a better way to express the original intent would be this:

	# comment added by $GIT_COMMITTER_NAME; fast-import should ignore it

Ciao,
Dscho