From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 04 Feb 2021 21:57:06 GMT
Subject: Re: [PATCH v4 2/3] range-diff/format-patch: handle commit ranges other than A..B
Message-ID: <nycvar.QRO.7.76.6.2102042256520.54@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqtuqr64oa.fsf@gitster.c.googlers.com>

Hi Junio,

On Thu, 4 Feb 2021, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > +test_expect_success 'A^! and A^-<n> (unmodified)' '
> > +	git range-diff --no-color topic^! unmodified^-1 >actual &&
> > +	cat >expect <<-EOF &&
> > +	1:  $(test_oid t4) = 1:  $(test_oid u4) s/12/B/
> > +	EOF
> > +	test_cmp expect actual
> > +'
>
> Now we actually parse the single-token range, instead of relying on
> "does it have dot-dot" heuristics, we can make sure that we reject
>
>     "HEAD^{/^string with .. in it}"
>
> as "not a range with negative and positive ends".

Sure, why not.

Ciao,
Dscho