From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 22 Apr 2020 11:27:39 GMT
Subject: Re: [gitgitgadget/git] Reftable support git-core (#539)
Message-ID: <nycvar.QRO.7.76.6.2004221327020.46@tvgsbejvaqbjf.bet>
In-Reply-To: <CAOw_e7azo1Wb9RO=7kH8kXp4RxTzD6SW4a9w_2ifiGxUmt2YKw@mail.gmail.com>

Hi Han-Wen,

On Mon, 20 Apr 2020, Han-Wen Nienhuys wrote:

> On Sat, Apr 18, 2020 at 5:26 AM gitgitgadget[bot] <notifications@github.com>
> wrote:
>
> > On the Git mailing list
> > <https://lore.kernel.org/git/20200418032252.GA9169@danh.dev>, Danh Doan
> > wrote (reply to this
> > <https://github.com/gitgitgadget/gitgitgadget/wiki/ReplyToThis>):
> >
> > On 2020-04-15 16:29:33-0700, Junio C Hamano <gitster@pobox.com> wrote:
> > > "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
> > >
> > > > This adds the reftable library, and hooks it up as a ref backend.
> > >
> > > Since I queued the topic to 'pu', I needed to apply these fix-up
> > > patches on top.  The change to the Makefile is about "make clean"
> > > which forgot to clean the reftable library.  All the rest are ws
> > > clean-ups.
> > >
> > > There are build breakages reported on Windows, with possible fixes
> > > (which IIRC were reported to segfault X-<), but I do not have URL or
> > > message-IDs handy.
> >
> > FYI, it's also segfault in Linux even if only the test is applied.
> > IOW, the code to fix breakages on Windows doesn't affect the segfault.
> >
> > Here is the message: <nycvar.QRO.7.76.6.2004101604210.46@tvgsbejvaqbjf.bet>
> >
> >
> Thanks for the reference. I'll look into it.
>
> Johannes, if you have specific comments about the reftable patch, please
> include me (hanwen@google.com) explicitly on your messages.

Sorry, I forgot. Will try to do better next time.

Ciao,
Dscho