From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 25 Dec 2019 12:02:53 GMT
Subject: Re: [PATCH 0/9] built-in add -p: add support for the same config settings as the Perl version
Message-ID: <nycvar.QRO.7.76.6.1912251259540.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqpngd60rx.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 24 Dec 2019, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > base-commit: 2d4b85ddc76af3e703e6e3a6a72319b5e79c2d8b
>
> It is not generally helpful to those who reads this list to use a
> commit that is not part of history leading to my 'pu' or 'next' as
> the base.

Right, but it _was_ part of `pu`. I based it directly on an earlier
version of `js/patch-mode-in-others-in-c`.

> I am guessing that it will build on top of the "use add -i/p from
> more commands" series, so I'll try to apply these on top there, but
> I wonder if it would help readers if we had some extra comments for
> human consumption next to "base-commit:" line (similar to the other
> stuff like Published-As added by GGG), perhaps in a format similar
> to the one we use to refer to random commits, e.g.
>
>     base-commit: 2d4b85ddc76af3e703e6e3a6a72319b5e79c2d8b
>     # commit --interactive: make it work with the built-in `add -i`, 2019-12-17
>
> perhaps?

This is actually the output of `git format-patch --base=...`. I agree that
your suggestion makes sense, and just like you suggested in another recent
mail, it would probably make sense for `git format-patch` to learn that
trick and for GitGitGadget to simply be just one of the users.

Ciao,
Dscho