From: Johannes Schindelin Date: Thu, 31 Oct 2019 11:27:54 GMT Subject: Re: Git for Windows v2.24.0-rc2, was Re: [ANNOUNCE] Git v2.24.0-rc2 Message-ID: In-Reply-To: <1223720779.572910.1572520655053@ox.hosteurope.de> Hi Thomas, On Thu, 31 Oct 2019, Thomas Braun wrote: > > Johannes Schindelin hat am 30. Oktober 2019 um 23:23 geschrieben: > > > - The `sendpack.sideband` config setting was re-introduced (I had > > dropped this by mistake, thinking that it was no longer necessary > > because the commit message failed to mention that this config setting > > is necessary to work around issues when pushing via `git://`). > > I do realize that my understanding of git is now much better than it > was 5 years ago when I submitted that patch. The commit message says > "dump git protocol" but actually wanted to say "git://". > > Thanks for reintroducing it. Thank you for your original contribution, and thanks to Oliver Schneider for reintroducing it! Now, if we only could make those `git daemon` tests to run on Windows... it should not be _all_ that hard, see https://github.com/git-for-windows/git/pull/2375#issuecomment-546744192... Ciao, Dscho