From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 27 Aug 2019 09:10:20 GMT
Subject: Re: [PATCH 04/11] hashmap_entry: detect improper initialization
Message-ID: <nycvar.QRO.7.76.6.1908271108410.46@tvgsbejvaqbjf.bet>
In-Reply-To: <20190826024332.3403-5-e@80x24.org>

Hi Eric,

On Mon, 26 Aug 2019, Eric Wong wrote:

> By renaming the "hash" field to "_hash", it's easy to spot
> improper initialization of hashmap_entry structs which
> can leave "hashmap_entry.next" uninitialized.

Would you mind elaborating a bit? This explanation does not enlighten
me, sadly, all I see is that it makes it (slightly) harder for me to
maintain Git for Windows' patches on top of `pu`, as the FSCache patches
access that field directly (so even if they rebase cleanly, the build
breaks).

Ciao,
Dscho