From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 25 Jul 2019 09:36:28 GMT
Subject: Re: [PATCH v2 3/5] repo-settings: parse core.untrackedCache
Message-ID: <nycvar.QRO.7.76.6.1907251131450.21907@tvgsbejvaqbjf.bet>
In-Reply-To: <49be7a73454b13b04270531eece87a2c6f6d3189.1564021393.git.gitgitgadget@gmail.com>

Hi Stolee,

On Wed, 24 Jul 2019, Derrick Stolee via GitGitGadget wrote:

> diff --git a/builtin/update-index.c b/builtin/update-index.c
> index dff2f4b837..5ced51c1ee 100644
> --- a/builtin/update-index.c
> +++ b/builtin/update-index.c
> @@ -18,6 +18,7 @@
>  #include "dir.h"
>  #include "split-index.h"
>  #include "fsmonitor.h"
> +#include "repo-settings.h"

Sorry, I only realized 10 seconds ago that these `#include`s are no
longer necessary because `repo-settings` is already included from
`repository.h` (and needs to be, because the `repository` struct now
contains a full `struct repo_settings` field, no longer just a pointer).

But really, I would just fold the `repo-settings.h` declarations
directly into `repository.h` (but keep `repo-settings.c`, of course!) as
it make everything a bit simpler.

Thanks,
Dscho