From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 03 Jul 2019 11:13:48 GMT
Subject: Re: What's cooking in git.git (Jun 2019, #07; Fri, 28)
Message-ID: <nycvar.QRO.7.76.6.1907031308150.44@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqftno2mku.fsf@gitster-ct.c.googlers.com>

Hi,

On Tue, 2 Jul 2019, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
>
> > * nd/index-dump-in-json (2019-06-26) 11 commits
> >  - SQUASH???
> >  - t3008: use the new SINGLE_CPU prereq
> >  - read-cache.c: dump "IEOT" extension as json
> >  - read-cache.c: dump "EOIE" extension as json
> >  - resolve-undo.c: dump "REUC" extension as json
> >  - fsmonitor.c: dump "FSMN" extension as json
> >  - split-index.c: dump "link" extension as json
> >  - dir.c: dump "UNTR" extension as json
> >  - cache-tree.c: dump "TREE" extension as json
> >  - read-cache.c: dump common extension info in json
> >  - ls-files: add --json to dump the index
> >
> >  "ls-files" learned "--debug-json" option to dump the contents and
> >  the extensions of the index file.
>
> The t3011 test in this topic seems timing-dependent-flaky.
>
> When we get "not ok 3 - ls-files --json, split index",
> the "filtered" one looks like this:
>
> $ diff -U999 t/t3011/split-index filtered
> --- t/t3011/split-index	2019-07-02 13:17:19.676719212 -0700
> +++ filtered	2019-07-02 13:40:32.068638361 -0700
> @@ -1,39 +1,19 @@
>  {
>    "version": 2,
>    "oid": <string>,
>    "mtime_sec": <number>,
>    "mtime_nsec": <number>,
>    "entries": [
> -    {
> -      "id": 0,
> -      "name": "",
> -      "mode": "100644",
> -      "flags": 0,
> -      "oid": <string>,
> -      "stat": {
> -        "ctime_sec": <number>,
> -        "ctime_nsec": <number>,
> -        "mtime_sec": <number>,
> -        "mtime_nsec": <number>,
> -        "device": <number>,
> -        "inode": <number>,
> -        "uid": <number>,
> -        "gid": <number>,
> -        "size": 4
> -      },
> -      "file_offset": <number>
> -    }
>    ],
>    "extensions": {
>      "link": {
>        "file_offset": <number>,
>        "ext_size": <number>,
>        "oid": <string>,
>        "delete_bitmap": [
>        ],
>        "replace_bitmap": [
> -        0
>        ]
>      }
>    }
>  }

ACK, I saw this quite a couple of times in the Azure Pipeline, too. It's
an unreliable test case all right.

Ciao,
Dscho