From: Johannes Schindelin Date: Wed, 03 Jul 2019 10:08:33 GMT Subject: Re: [PATCH v3 00/10] grep: move from kwset to optional PCRE v2 Message-ID: In-Reply-To: Hi Junio, On Tue, 2 Jul 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Please note that the problem is _not_ MinGW! The problem is that the > > non-JIT'ted code path is a lot more stringent than the JIT'ted one. So > > what you'd need is a prerequisite that tests whether the PCREv2 in use > > supports JIT'ted code or not, and skip the test case in the latter one. > > Hmph, so additional prereq !MINGW may happen to match "do we use > pcre sans jit?" but not a right thing to use here? That's right, the `!MINGW` prereq works by happenstance only, and as soon as I find some time to rebuild PCREv2 with JIT support, it will stop doing the right thing. Which might happen very soon. Quite honestly, I'd rather introduce a prerequisite here that specifically tests whether the output of a `git grep -P` suggests that it has been fed incorrect UTF-8, and skip the test case under that circumstance. Ciao, Dscho