From: Johannes Schindelin Date: Mon, 24 Jun 2019 18:00:20 GMT Subject: Re: [PATCH v2 00/10] Add 'ls-files --debug-json' to dump the index in json Message-ID: In-Reply-To: <20190624130226.17293-1-pclouds@gmail.com> Hi Duy, On Mon, 24 Jun 2019, Nguyễn Thái Ngọc Duy wrote: > - json field names now use '_' instead of '.' to be friendlier to some > languages. I stick to underscore_name instead of camelCase because > the former is closer to what we use This is not a good reason. People who are used to read JSON will stumble over this all the time because it is so uncommon. > - extension location is printed, in case you need to decode the > extension by yourself (previously only the size is printed) > - all extensions are printed in the same order they appear in the file > (previously eoie and ieot are printed first because that's how we > parse) > - resolve undo extension is reorganized a bit to be easier to read > - tests added. Example json files are in t/t3011 It might actually make sense to optionally disable showing extensions. You also forgot to mention that you explicitly disable handling ``, which I find a bit odd, personally, as that would probably come in real handy at times, especially when we offer this as a better way for 3rd-party applications to interact with Git (which I think will be the use case for this feature that will be _far_ more common than using it for debugging). Ciao, Dscho