From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 06 Jun 2019 12:52:42 GMT
Subject: Re: [PATCH v3] config: learn the "onbranch:" includeIf condition
Message-ID: <nycvar.QRO.7.76.6.1906061452130.42@tvgsbejvaqbjf.bet>
In-Reply-To: <49e22269d5a66d1975fca71a300e9099f46e1c40.1559769658.git.liu.denton@gmail.com>

Hi Denton,

On Wed, 5 Jun 2019, Denton Liu wrote:

> Currently, if a user wishes to have individual settings per branch, they
> are required to manually keep track of the settings in their head and
> manually set the options on the command-line or change the config at
> each branch.
>
> Teach config the "onbranch:" includeIf condition so that it can
> conditionally include configuration files if the branch that is checked
> out in the current worktree matches the pattern given.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>
> Thanks for the review, Johannes and Duy. I've incorporated both of your
> suggestions into this round.
>
> Notes:
>     Changes since v2:
>
>     * Run test-cases outside foo/ since the subdirectory is not necessary

That should indeed take care of my concern. Thank you!
Dscho