From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 26 Jun 2018 22:08:17 GMT
Subject: Re: [PATCH v6 3/4] stash: update test cases conform to coding guidelines
Message-ID: <nycvar.QRO.7.76.6.1806270003150.21419@tvgsbejvaqbjf.bet>
In-Reply-To: <2fe77c0946231dd9235d88922e4d56dd7f5c66c7.1529943789.git.ungureanupaulsebastian@gmail.com>

Hi Paul,

On Mon, 25 Jun 2018, Paul-Sebastian Ungureanu wrote:

> Removed whitespaces after redirection operators.

That is accurate a description of what the patch does. Let's add the why
(and change the tense to present tense, as is the custom in our commit
messages):

	This adjusts t3903-stash.sh to conform with our coding conventions
	better, by removing whitespace between redirection operators and
	their file names.

The patch does two more things, though: it breaks at least one long line,
and it renames at least two non-descriptive files to the much better name
`expected`. Maybe you want to mention that in the commit message, to?

Thanks,
Dscho