From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 26 Jun 2018 22:02:22 GMT
Subject: Re: [PATCH v6 1/4] sha1-name.c: added 'get_oidf', which acts like 'get_oid'
Message-ID: <nycvar.QRO.7.76.6.1806270000180.21419@tvgsbejvaqbjf.bet>
In-Reply-To: <4c1f71b067ac235c3003d58e1f3dfb07866be129.1529943789.git.ungureanupaulsebastian@gmail.com>

Hi Paul,

as a general rule, we try to keep the commit subjects in the imperative,
i.e.

	sha1-name.c: add 'get_oidf', which acts like 'get_oid'

On Mon, 25 Jun 2018, Paul-Sebastian Ungureanu wrote:

> Compared to 'get_oid', 'get_oidf' has as parameters a
> printf format string and the additional arguments. This
> will help simplify the code in subsequent commits.

Good. The patch is obviously correct, from my perspective.

Ciao,
Dscho