From: Johannes Schindelin Date: Tue, 26 Jun 2018 12:57:37 GMT Subject: Re: [GSoC][PATCH 1/1] sequencer: print an error message if append_todo_help() fails Message-ID: In-Reply-To: <20180626100429.10169-2-alban.gruin@gmail.com> Hi Alban, On Tue, 26 Jun 2018, Alban Gruin wrote: > This adds an error when append_todo_help() fails to write its message to > the todo file. > > Signed-off-by: Alban Gruin ACK. We *may* want to fold that into the commit that adds `append_todo_help()`. And, as I mentioned previously, I would love for that function to be used as an excuse to introduce the long-overdue `interactive-rebase.c` (`sequencer.c` is supposed to be the backend for cherry-pick and revert and interactive rebase, but not a catch-all for *all* of those things, it is already way too long to be readable, and I take blame for a large part of that.) Ciao, Dscho