From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 20 Apr 2018 13:57:46 GMT
Subject: Re: [PATCH v2 2/7] replace: introduce --convert-graft-file
Message-ID: <nycvar.QRO.7.76.6.1804201540310.4241@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
In-Reply-To: <CAP8UFD3cH4JkKo97o4k+BW=sdaFviJR06R1V_JqS9FkwuP7ZKw@mail.gmail.com>

Hi Christian,

On Thu, 19 Apr 2018, Christian Couder wrote:

> On Thu, Apr 19, 2018 at 10:17 AM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> 
> > @@ -87,9 +88,13 @@ OPTIONS
> >         content as <commit> except that its parents will be
> >         [<parent>...] instead of <commit>'s parents. A replacement ref
> >         is then created to replace <commit> with the newly created
> > -       commit. See contrib/convert-grafts-to-replace-refs.sh for an
> > -       example script based on this option that can convert grafts to
> > -       replace refs.
> > +       commit. Use `--convert-graft-file` to convert a
> > +       `$GIT_DIR/info/grafts` file use replace refs instead.
> 
> s/file use replace refs/file to use replace refs/

Ouch... thanks for catching this!

> > +--convert-graft-file::
> > +       Creates graft commits for all entries in `$GIT_DIR/info/grafts`
> > +       and deletes that file upon success. The purpose is to help users
> > +       with transitioning off of the now-deprecated graft file.
> 
> I wonder if it would be better to rename the file to "old_grafts" or
> something, and perhaps tell the user that we renamed it and it can now
> be either deleted or moved somewhere else.

I do not think so. Those old_grafts will only lie around uselessly... and
are no longer necessary.

Ciao,
Dscho