From: Johannes Schindelin Date: Mon, 26 Feb 2018 20:49:20 GMT Subject: Re: [PATCH v4 00/12] rebase -i: offer to recreate merge commits Message-ID: In-Reply-To: Hi Jake, On Sun, 25 Feb 2018, Jacob Keller wrote: > On Fri, Feb 23, 2018 at 4:35 AM, Johannes Schindelin > wrote: > > Changes since v3: > > > > - fixed a grammar error in "introduce the `merge` command"'s commit message. > > > > - fixed a couple of resource leaks in safe_append() and do_reset(), pointed > > out by Eric Sunshine. > > > > The interdiff seems incorrect for such a small list of changes, it > appears like large sections of code added by this series appear in the > interdiff without subtractions from the previous versions? Is all that > code new to v3? If not, I'd suspect you accidentally diffed between > the wrong points. Indeed, it seems that I messed this iteration up rather well. Will redo. Ciao, Dscho