From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 10 Sep 2021 15:20:24 GMT
Subject: Re: [PATCH v2 5/8] http: correct version check for CURL_HTTP_VERSION_2
Message-ID: <nycvar.QRO.7.76.2109101713110.2614@fvyyl>
In-Reply-To: <YTt1RLty0KDEAio1@coredump.intra.peff.net>

On Fri, 10 Sep 2021, Jeff King wrote:

>> The newest symbol we depend on is CURL_HTTP_VERSION_2. It was added in 
>> 7.33.0, but the CURL_HTTP_VERSION_2 alias we used was added in 7.47.0. So 
>> we could support an even older version here, but let's just correct the 
>> checked version.
>
> Thanks for expanding on the history here. I agree it probably doesn't matter 
> much between the two versions, as they're both 6+ years old (and only about 
> 6 months apart). If somebody has a case where it really matters, they can 
> submit a patch.

Forgive me for digressing a bit here but wow, I *so* appreciate your digging 
into the details of the curl history and the symbols that were introduced when 
etc. I know of no other libcurl-using project with this eye and sense for 
historic details and as the lead maintainer of libcurl I learn a lot here. It 
also keeps me motivated to provide this documentation and work on keeping in 
accurate.

Keep it up! <3

-- 

  / daniel.haxx.se